Closed
Conversation
Member
|
@nicorikken thanks for the PR. I need at least several days to follow up on this |
Member
|
@nicorikken boot has no problem any more with large metadata, so you can use regular way to pass metadata. |
Contributor
@podviaznikov by that you mean using |
Member
|
@martinklepsch yes, I think so |
Contributor
Author
|
I think it's fair to say this PR is soon to be replaced by PR #100 which uses the power of AsciidoctorJ's JRuby wrapper, instead of a DIY solution. I'd still have to get the libraries like |
Closed
|
Deployed |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A basic Asciidoctor plugin, which also features the ability to generate diagrams (PlantUML) and parse basic metadata from the adoc file.
THIS PLUGIN USES A FILE-BASED CONTENT TRANSPORT RATHER THAN A METADATA WAY. It is therefore not (yet) fully compatible with the other Perun modules.
This plugin adds the Asciidoctor functionality by including a Jruby Asciidoctor implementation. The resulting content is provided to the render stage using files rather than a string in the metadata. This was done to cope with string size limitations on the metadata, which was a constraint for the use-case this plugin was designed for. This plugin can be improved by adding support for metadata-based content handing, adding an Asciidoctor attribute parser, and further separating dependencies by wrapping it in a separate pod.