Open
Conversation
nicorikken
force-pushed
the
fix-asciidoc-yaml-parsing
branch
from
35e1b1d to
988bd41
Compare
Contributor
Author
|
I just changed the PR to use lookbehind rather than a match, as the match could not cope with a the two |
Fixes the issue as described in hashobject#192 by checking the triple dash to be prefixed by either the start of the document, or the start of a new line. This does still allow for some content before the actual yaml.
nicorikken
force-pushed
the
fix-asciidoc-yaml-parsing
branch
from
988bd41 to
0861b0c
Compare
Contributor
Author
|
Again I just changed the PR, as I made a typo in the lookbehind syntax, causing false matches. |
podviaznikov
approved these changes
Nov 14, 2017
Member
|
this will be tricky one. We need to test this somehow. High risk it might break people's sites. |
Member
|
maybe we can include couple of tests? |
Contributor
|
Hi, @nicorikken Still working on this? Any news regarding @podviaznikov's suggestion? |
allentiak
suggested changes
Feb 28, 2019
Contributor
allentiak
left a comment
allentiak
left a comment
There was a problem hiding this comment.
(Just to make @podviaznikov's feedback explicit.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue as described in #192
by checking the triple dash to be prefixed by either the start of the document,
or the start of a new line. This does still allow for some content before the
actual yaml.