Conversation
Also, make arguments a map, to match other pre-wraps
Contributor
Author
|
I should have mentioned - there is one backwards-incompatible change to |
podviaznikov
approved these changes
Jan 23, 2017
Member
podviaznikov
left a comment
podviaznikov
left a comment
There was a problem hiding this comment.
Same comment as before.
Code looks good to me.
Only one ask would be to add use of assortment and paginate tasks into the example project https://github.com/hashobject/perun/tree/master/examples/blog
Contributor
Author
|
The last commit merged #141 here, for conflict avoidance. |
podviaznikov
approved these changes
Jan 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a
tagstask that creates an html file for each tag found in the:tagsmetadata of existing html files. The render function provided to the task will be called for each file to be generated a data structure in the same shape as the one provided to thecollectiontask, a map with:entry,:entriesand:metakeys.The
assortmenttask (first discussed in #109) comes along for the ride here, becausetagsis a subset ofassortment.This will probably conflict with other pull requests that I'm submitting at the same time, but they'll be trivial for me to fix as they get merged.