Stop RPC materializer retries when ACL token is not found#23606
Open
melkor217 wants to merge 1 commit into
Open
Stop RPC materializer retries when ACL token is not found#23606melkor217 wants to merge 1 commit into
melkor217 wants to merge 1 commit into
Conversation
Treat ACL not found as a terminal subscribe error on client agents so streaming health subscriptions exit instead of retrying until idle eviction. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Before the fix (consul 1.22.5) |
Author
|
After the fix: Only first error with failure_count=1 appears, no retries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACL not foundas a terminal error inRPCMaterializer, matching existingLocalMaterializerandagent/cachebehaviorFixes repeated
agent.rpcclient.health: subscribe call failederrors reported in #22515 (Nomad workload identity / consul-template).Test plan
go test ./agent/submatview/... -count=1{{ range service "..." }}template, stop the allocation, confirm no ongoingsubscribe call failed/ACL not founderrors in Consul logsMade with Cursor