fix: stream ZIP uploads into isolated temporary files - #2
Open
harshitethic wants to merge 4 commits into
Open
harshitethic wants to merge 4 commits into
harshitethic wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ZIP uploads were buffered fully in memory and written to a predictable temporary path derived from the uploaded filename:
Two concurrent uploads using the same filename could therefore write to the same temp file. One request could overwrite or delete the file while the other request was still processing it.
The endpoint also allocated up to ~50 MB per upload in one Python bytes object before writing anything to disk, which scales poorly with concurrent requests.
Fix
NamedTemporaryFile(delete=False)so every request receives a unique temp path;UploadFileinto the temp file in 1 MiB chunks instead of buffering the entire archive;Tests
Adds coverage for:
This keeps the public upload API unchanged while making concurrent uploads deterministic and reducing per-request memory pressure.