security: keep indexed files inside the cloned repository - #1
Open
harshitethic wants to merge 3 commits into
Open
harshitethic wants to merge 3 commits into
harshitethic wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RepoPilot recursively indexes files from cloned repositories and later reads those files into search/AI context.
The existing
iter_files()implementation trustedPath.is_file(). That follows file symlinks, so a repository containing a symlink to a file outside the clone could cause RepoPilot to index and read host-side content.Example:
Because RepoPilot sends selected repository context to the local model, this violates the intended repository boundary even though cloned project code is never executed.
Fix
Tests
Adds regression tests proving:
The backend CI job now runs the unittest suite in addition to bytecode compilation.
Scope
This protects RepoPilot's read/index boundary. It does not add code execution or change the local-only Ollama behavior.