feat: manage workspace inventory, deletion, and stale cleanup - #11
Open
harshitethic wants to merge 3 commits into
Open
harshitethic wants to merge 3 commits into
harshitethic wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PatchPilot creates a new on-disk clone for every agent run, but there is currently no lifecycle API for those workspaces. Long-running local instances can therefore accumulate clones indefinitely, and clients cannot enumerate or explicitly dispose of completed runs.
What changed
Adds a contained workspace lifecycle layer:
GET /api/workspaces— list valid workspaces with current branch, dirty-file count, and UTC update time;DELETE /api/workspaces/{workspace_id}— remove one workspace;POST /api/workspaces/cleanup— remove workspaces older than a bounded age (1 hour to 30 days).Safety
Workspace directory resolution is centralized in
workspace_dir()and constrained beneath.workspacesbefore any read or delete operation.Cleanup independently resolves every candidate beneath the workspace root before deletion, skips invalid/unreadable entries, and only removes entries older than the requested cutoff.
Tests
Regression coverage verifies:
../outsideare rejected and leave external directories untouched;The existing single-workspace inspection API remains unchanged. Documentation includes the new lifecycle endpoints and retention semantics.