Repository navigation
site: the hero has no fallback version number - #180
Merged
Merged
Conversation
The hero printed VERSION = "3.0.6" whenever assets/version.txt could not be read, a literal that only ever goes stale. With no fallback number, a failed fetch leaves the version out of the banner instead. Checked both ways: with the file the banner reads v3.16.0, without it the version is simply absent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #178, raised by Marketing. When
assets/version.txtcan't be read, the hero printed a hard-coded3.0.6, a fallback that only ever goes stale.Now there's no fallback number: if the fetch fails, the banner leaves the version out.
Checked both ways, with the file blocked in the second case:
reminal — remote terminal · v3.16.0 · [HOST]reminal — remote terminal · [HOST]🤖 Generated with Claude Code