Repository navigation
site: the hero's version is the newest release tag - #178
Merged
Merged
Conversation
build.sh stamped public/assets/version.txt with the nearest tag of any kind. A checkout carrying other tags got a non-version (the hero rejects it and prints its fallback, 3.0.6, which is what reminal.app shows now), and the nearest release in a checkout's history can be an older one. It now takes the newest vX.Y.Z tag by version: v3.16.0 today, matching the latest GitHub release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reminal.app's hero terminal prints
reminal — remote terminal · v3.0.6. That's the page's hard-coded fallback, not the current release.Why:
build.shwroteassets/version.txtfromgit describe --tags --abbrev=0, the nearest tag of any kind. A checkout that carries other tags gets a non-version string, which the hero's check (^\d+\.\d+\.\d+$) rejects, so it falls back to 3.0.6. And even restricted tov*, the nearest release in a checkout's history can be an older one (I saw v3.15.6 where v3.16.0 is the latest).Fix: take the newest
vX.Y.Ztag by version (git tag --list 'v[0-9]*' --sort=-v:refname, filtered to plainX.Y.Z, so release candidates are skipped). It gives v3.16.0 in every checkout I tried, matching GitHub's "Latest" release.build.shwrites3.16.0toversion.txt.🤖 Generated with Claude Code