Repository navigation
fix: show bundled workflows an upgrade has not copied - #69
Merged
Merged
Conversation
An older project only listed workflows already on disk, and init --force would not record a file that matched the bundle when the manifest had no hash. sdd workflows now names the missing packs, and a matching unmarked file is recorded so a later --force can refresh it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36. An upgraded CLI no longer hides bundled workflows that the project has not copied, and
sdd init --forcecan refresh a file that still matches the bundle even when.sdd/.generated.jsonhas no hash for it.sdd workflowsstill lists the project workflows. It addsNot copied yet: …when this CLI ships packs that are not in.sdd/workflows/.sdd new -w <name>still refuses a name that is not in the project. When the CLI ships that name, the error tells you to runsdd init --here --force.--forcecan refresh it. A file that differs stays kept and gets no hash.sdd initwithout--forcestill does not copy workflows or rewrite config.Test plan
tsc --noEmitfor core and clibiome checkonpackages/core/srcandpackages/cli/src(pre-commit)