feat: persist session state to ~/.reqsh_state.json#20
Merged
Conversation
- Add Serialize/Deserialize to Request and Method - Add save/load methods to ShellState using serde_json - Restore state on startup, fallback to empty state on error - Skip last_request during serialization as it is transient - Add unit tests for state serialization roundtrip Closes hars-21#12
hars-21
requested changes
Jul 7, 2026
hars-21
left a comment
Owner
There was a problem hiding this comment.
Pressing Ctrl+D (EOF) or Ctrl+C (Interrupted) skips save(). Users will lose state unexpectedly.
Add save() calls in both the branches
| base_url: Option<String>, | ||
| headers: HashMap<String, String>, | ||
| variables: HashMap<String, String>, | ||
| #[serde(skip)] |
Owner
There was a problem hiding this comment.
Do not skip timeout as running reqsh --timeout 30 discards any previously saved session state.
Contributor
Author
|
Fixed |
hars-21
approved these changes
Jul 8, 2026
Owner
|
Awesome work thanks for contributing! I've merged your PR. Looking forward to seeing more contributions from you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12