feat: Add typed qualifier to runtime path + custom qualifier to precompiled path#204
Merged
Merged
Conversation
harrytmthy
enabled auto-merge (squash)
April 25, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds custom qualifier annotation support to Stitch's precompiled path, including field injection, constructor injection,
@Provides,@Binds, dependency resolution, and generatedInjector.get(...)support.Implementation Details
Qualifier resolution is now derived directly from each annotated symbol instead of relying on a predefined qualifier scan phase, which allows Stitch to recognize custom marker qualifiers annotated with
@Qualifier, even when they come from other modules. This PR also adds validation to reject multiple qualifiers on the same symbol, introducesQualifier.Customin the KSP model, and updates generated injectors to resolve custom qualifiers through bothnamed(...)and the new type-basedtyped(...)runtime qualifier. Together, these changes make common Dagger and Hilt qualifier patterns such as@Productionand@Stagingwork end-to-end in Stitch's precompiled path.Closes #203