refactor(runtime): Resolve scoped factory dependencies in the owning scope#198
Merged
Merged
Conversation
harrytmthy
force-pushed
the
refactor/scoped-factory-dependency-resolution
branch
from
April 23, 2026 11:32
4224699 to
cb0e9da
Compare
harrytmthy
enabled auto-merge (squash)
April 23, 2026 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes runtime parent-child scoped resolution so nested
get()calls inside scoped factory lambdas resolve in the binding's owning scope instead of the original requesting scope.Implementation Details
ResolutionContextnow updates its active scope while a binding is being resolved, allowing scoped factory dependencies to follow the visibility of the owning scope when ancestor-owned bindings are built from child scopes. This restores correct runtime scope semantics for hierarchical scoped resolution and prevents incorrect dependency traversal in nestedget()calls. The PR also includes a small cleanup aroundModuleinitialization and registration API shape.Closes #197