Repository navigation
perf(scan): type-check every app's config package in one load - #54
Merged
Merged
Conversation
Scanner caches the Config struct it type-checks, and Lint prepares every app's config package in a single packages.Load before it fans out. Apps share nearly all of their dependency graph, so loading them together costs about what loading one of them costs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint spends nearly all of its time in the config scan, and almost none of that time is really about the config. Scanning a package with go/packages in NeedTypes mode makes the Go toolchain build export data for everything the package imports, and an app config that embeds a shared struct drags in that struct's whole world.
Lint now asks the scanner to type-check every app's config package in one packages.Load before it fans out, and Scanner remembers what it type-checked.
One caveat for callers: the batched load only pays off when the directories resolve together. A repo of separate modules needs a go.work for this to do anything, and a consumer that sets GOWORK=off will silently get the old per-directory behaviour.