test: regression coverage for HAR/SCS #1030 and recent renames - #1054
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add tests for HAR search_term query mapping, artifact deep links, UPSTREAM authType schema docs, SCS artifact deep link placeholders, compact marker fields, observability_eval rename, and pr_comment execute action surface. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for production fixes merged since the last coverage automation run, focusing on #1030 (HAR/SCS query params, deep links, compact markers) plus small guards for #1043/#1045.
Risky behavior now covered
search_termmust map to thesearch_termquery key (not a silentsearchkey) on registry/artifact/artifact_version/artifact_file list.pathParamsmust resolve{artifactIdentifier}in per-itemopenInHarnessURLs.registrycreatebodySchemadocuments requiredauthTypefor UPSTREAM registries.artifact_security,scs_artifact_remediation, andscs_chain_of_custodymust resolve{artifact}fromartifact_id(not leave placeholders)._summary,_message,_resultmarker fields from SCS list extractors survive default compaction.observability_evaluation_ruleis not registered;pr_commentexecute surface is onlyresolve/unresolveafter Remove redundant pr_comment set_status action #1043.Test files added/updated
tests/registry/registries-har-search-deeplinks.test.ts(new)tests/registry/scs.test.tstests/utils/compact.test.tstests/registry/observability-evaluations.test.tstests/registry/pull-requests.test.tsWhy these tests materially reduce regression risk
These paths were fixed without accompanying tests in #1030; failures were silent (search filters ignored, broken UI deep links, stripped agent hints). The new tests lock the wire-format and deep-link contracts agents rely on during registry and supply-chain workflows.
Type of Change
Checklist
pnpm testpasses (targeted: registries-har-search-deeplinks, scs, compact, observability-evaluations, pull-requests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpassesCoding Standards (registry-driven MCP model)
N/A — test-only change.