Repository navigation
test: regression coverage for HAR/SCS #1030 fixes - #1050
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Lock search_term query mapping, artifact deep links, SCS {artifact}
placeholder alignment, and compact marker field preservation.
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for production fixes merged in #1030 where list
search_termwas mapped to a bogussearchquery key, HAR artifact deep links left{artifactIdentifier}unresolved, SCS deep link templates used{artifactId}instead of{artifact}, andcompactItemsstripped SCS_summary/_message/_resultmarkers.Risky behavior now covered
registry,artifact,artifact_version, andartifact_filelist ops must sendsearch_termto the HAR API (notsearch), or search filters silently do nothing.artifactlist must mapartifact_id→artifactIdentifiersoopenInHarnessURLs are usable.harness_schemadocs forregistrycreate must document requiredconfig.authTypefor UPSTREAM registries.artifact_security,scs_artifact_remediation, andscs_chain_of_custodytemplates andgetresponses must resolve{artifact}without literal placeholders.compactItemsmust preserve_summary,_message, and_resultfields attached by SCS list extractors.Test files added/updated
tests/registry/registries-har-search-deeplinks.test.ts(new)tests/registry/scs.test.tstests/utils/compact.test.tsWhy these tests materially reduce regression risk
These bugs were discovered during live QA: incorrect query-param keys and pathParam/deep-link mismatches fail silently (empty results or broken UI links) rather than with obvious API errors. The tests assert the exact HTTP query keys, pathParam mappings, schema documentation strings, and compaction whitelist behavior so a revert of #1030 would fail CI immediately.
Validation
pnpm test tests/registry/registries-har-search-deeplinks.test.ts tests/registry/scs.test.ts tests/utils/compact.test.ts— 315 tests passedType of Change
Checklist
pnpm testpasses (targeted suites above)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses