Repository navigation
feat: add fme_change_request resource - #1049
Open
MatiasCasaliSplit wants to merge 2 commits into
Open
MatiasCasaliSplit wants to merge 2 commits into
MatiasCasaliSplit wants to merge 2 commits into
Conversation
Read-only list of FME change requests via GET /fme/api/v4/change-requests. Project-scoped by default, account-wide with resource_scope='account'. Filters: status, filter, environment_id, resource_type, segment_type, offset/limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> AI-Session-Id: 5a5ac74a-f1b4-4630-a714-f0bb6efc222b AI-Tool: claude-code AI-Model: unknown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Adds the read-only
fme_change_requestresource (listonly), backed byGET /fme/api/v4/change-requests. It is Harness-native only. Scope is project by default (org_id+project_id). Passresource_scope='account'to list across the whole account.WHY
Agents can list pending change requests (FME approval workflow items) for feature flags and segments without knowing the flag or segment name first. For example, they can answer "what's waiting on my approval?" with
filter=APPROVALS.Changes
src/registry/toolsets/feature-flags.ts: adds thefme_change_requestresource (supportedScopes: ["account", "project"],FME_HARNESS_NATIVE_SCOPE_PARAMS).status(repeatable, defaults server-side to[REQUESTED])filter(ALLdefault /APPROVALS/SUBMISSIONS)environment_id(repeatable)resource_type(FEATURE_FLAG/SEGMENT)segment_type(STANDARD/LARGE/RULE_BASED)offset/limit(harness_listsizemaps tolimit, as on the other FME v4 lists)status/environment_idare sent as repeated query params. Enum values are canonicalized case-insensitively.segment_typewithoutresource_type=SEGMENT(and the reverse), and a missingorg_id/project_idwithoutresource_scope='account'.skipCompact: the generic whitelist would dropresourceName,resourceType,environment,createdByandapprovalConfig.tests/registry/feature-flags.test.ts: 12 tests covering routing, account scope, filter mapping, CSV splitting and case canonicalization, validation errors, the extractor, and resource metadata.README.md: resource table row, a notes bullet, the toolset list, and the regenerated counts (260 resource types).Testing
pnpm build,pnpm typecheck,pnpm standards:check(79 passed),pnpm docs:checkall pass.pnpm test: 171 files, 3937 tests, all passing.HarnessClient.buildUrlagainst a local service-web-admin, and every request returned 200 with the expected filtering. The calls covered:statusvalues withfilter=SUBMISSIONSandlimit=5filter=APPROVALSresource_type=FEATURE_FLAGresource_type=SEGMENT&segment_type=STANDARDenvironment_idvalues