Repository navigation
feat: add rule and tags support to fme_experiment - #1048
Merged
puthrayaharness merged 1 commit intoOct 3, 2026
Merged
Conversation
Create and update accept rule and tags; create defaults rule to "default" when omitted. List accepts a tags filter, and list items keep tags and rule. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
puthrayaharness
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
ruleandtagssupport to thefme_experimentresource:rule(defaults to"default"when omitted or null) andtags([{name}]).rule(nullclears) andtags(replacement list;nullor[]clears). Omitting either leaves it unchanged.tagsarray filter (experiments having any of the given tag names); list items now keeptagsandrulein the compacted output.Why
The v4 experiments API now exposes
ruleandtagson read, create and update, and atagslist filter. Without this, agents cannot scope an experiment to a targeting rule, manage its tags, or filter by tag.Testing
pnpm vitest run tests/registry/feature-flags.test.ts: 212 passed.pnpm build: passed.pnpm standards:check: 79 passed.pnpm docs:generatethenpnpm docs:check: README up to date.pnpm testnot run.anotherorg, projectprojectA), on an existing test experiment, restored afterwards:tagsfilter: single tag and any-of ([nonexistent, existing]) return the tagged experiment; a nonexistent tag returns none. Items includetags.rule: "default": accepted and returned as"default".tagsreplacement,tags: [], andrule: nullall behave as documented.rule/tagswas not exercised live (unit-tested only).🤖 Generated with Claude Code