Repository navigation
feat: add fme_experiment_alerting resource - #1047
Merged
puthrayaharness merged 2 commits intoOct 3, 2026
Merged
Conversation
Adds get/update for an experiment's alerting subscription, backed by
/fme/api/v4/experiments/{id}/alerting. Harness-native scope only; update is
a JSON Merge Patch with a required isEnabled.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
AI-Session-Id: 374dfc37-c793-4d73-9874-704ef0c9e2be
AI-Tool: claude-code
AI-Model: unknown
Document 400/403 on update and that the degradation threshold is not editable, drop client-irrelevant implementation notes, fix the stale buildFmeMergePatch comment, and cover body-key stripping and missing identifier/scope on update. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> AI-Session-Id: 374dfc37-c793-4d73-9874-704ef0c9e2be AI-Tool: claude-code AI-Model: unknown
puthrayaharness
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Adds the
fme_experiment_alertingresource withgetandupdate, backed by/fme/api/v4/experiments/{id}/alerting. It is Harness-native only (org_id+project_id).getreturns{id, isEnabled}. It reportsisEnabled: falsewhen no alert policy exists and only 404s when the experiment doesn't exist.updateis a JSON Merge Patch with a requiredisEnabledboolean. The response is the flattened{id, isEnabled, governance}.tests/registry/feature-flags.test.tsand README updates.WHY
Lets agents read and toggle whether an experiment is subscribed to significance-regression alerting, alongside the existing
fme_experiment,fme_experiment_settingsandfme_experiment_resultresources.Testing
tests/registry/feature-flags.test.tspasses, as dopnpm build,pnpm standards:checkandpnpm docs:check.tests/scripts/ip-address-security-lib.test.ts, which fail identically on cleanmain.get,updatewithtrueandfalse(persisted), a missingisEnabledrejected, and a 404 for a nonexistent experiment.🤖 Generated with Claude Code