Repository navigation
test: regression coverage for HAR/SCS #1030 fixes - #1046
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Lock search_term query mapping, artifact deep links, SCS {artifact}
placeholder alignment, and compact marker field preservation.
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for merged #1030 fixes where silent failures were discovered during QA (search filters dropped, unresolved deep-link placeholders, compact stripping SCS marker rows).
Risky behavior now covered
registry,artifact,artifact_version, andartifact_filelist ops must sendsearch_termon the wire (not a bogussearchkey).{artifactIdentifier}inopenInHarnessURLs.configbodySchema documents requiredauthTypefor UPSTREAM registries.artifact_security,scs_artifact_remediation, andscs_chain_of_custodydeep links use{artifact}consistent withpathParams.artifact_id → artifact.compactItemskeeps_summary,_message, and_resultmarker objects from SCS extractors.Test files added/updated
tests/registry/registries-har-search-deeplinks.test.ts(new)tests/registry/scs.test.tstests/utils/compact.test.tsWhy these tests materially reduce regression risk
Each failure mode was silent (filter ignored, placeholder left in UI links, agent guidance stripped). These dispatch-level and compaction tests fail loudly if query-param maps, pathParams, or ALWAYS_KEEP drift again.
Type of Change
Checklist
pnpm testpasses (targeted: registries-har-search-deeplinks, scs deep-link block, compact markers)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses