fix: keep HAR list search when callers use the describe filter - #1042
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
harness_describe still advertises search for registry, artifact, and artifact version lists. The query map only read search_term, so that filter was dropped and the API returned an unfiltered page. Accept both input names and send the HAR search_term query parameter. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
harness_listsearch for v1 registries, artifacts, and artifact versions silently returned an unfiltered page when the caller used the filter name fromharness_describe.queryParamsmaps an input key to an API query key. HAR list endpoints expect the query parametersearch_term.harness_describeadvertises that filter assearch, andharness_listalso has a top-levelsearch_termargument. A recent change kept only thesearch_terminput key, sofilters.searchwas dropped before the request. The API then returned the full page.Both input names now map to
search_term. When both are set,search_termwins.Type of Change
Checklist
pnpm testpasses (172 files, 3934 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (architecture guardrails — see docs/coding-standards.md)pnpm docs:checkpasses (if registry/tool counts changed)Coding Standards (registry-driven MCP model)
If this PR adds or changes Harness API coverage:
server.registerTool()calls — only toolset definitions insrc/registry/toolsets/ALL_TOOLSETSandToolsetNameunionoperationPolicyon every new/changed endpointsrc/registry/extractors.ts(no raw passthrough on real endpoints)identifierFieldsandscopedeclared on new resourcesconsole.log()insrc/(stdio JSON-RPC safety)