test: HAR/SCS regression coverage for #1030 fixes - #1041
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
) Add dispatch-level tests ensuring HAR list ops send search_term on the wire, artifact list deep links resolve artifactIdentifier, and compactItems retains SCS marker fields. Align SCS supply-chain deep link templates with pathParams. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for merged fix #1030 (HAR registry/SCS query params, path params, and compact whitelist).
Risky behavior now covered
registry,artifact,artifact_version, andartifact_filelist ops must sendsearch_termas the API query key (not a brokensearchalias).artifactlist must resolve{artifactIdentifier}inopenInHarnesswhen items includeartifactIdentifier/registryIdentifier.artifact_security,scs_artifact_remediation, andscs_chain_of_custodydeep link templates must use{artifact}consistent withpathParams.artifact_id → artifact.compactItemsmust retain_summary,_message, and_resultmarker rows from SCS extractors.Test files added/updated
tests/registry/har-registries-regression.test.ts(new)tests/utils/compact.test.tstests/registry/scs.test.tsWhy these tests materially reduce regression risk
Dispatch-level assertions catch wire-format mistakes that static schema checks miss; deep-link tests prevent unresolved Harness UI placeholders; compact whitelist tests protect agent-facing SCS summaries from being stripped on list responses.
Type of Change
Checklist
pnpm testpasses (focused: har-registries-regression, compact, scs)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses