Resolve remaining v1.1.0 API issues - #211
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the four remaining v1.1.0 milestone API issues in one coherent change:
Player.nativePlaybackStateas the synchronous native-state query while documenting the distinction from the observablestatemirror (Expose a public synchronous native playback state #70)VLCError.rendererFailederror when applying a renderer fails (Add a dedicated VLCError case for renderer application failure #71)voutChanged, keeping video dimensions current (Refresh videoTracks dimensions on .voutChanged #73)Media(url:)initializer ABI (Add a typed Media initializer for HTTP user-agent and referer #74)The renderer paths share one native application helper, and each behavior has deterministic regression coverage. Documentation and architecture guidance are updated with the new contracts.
Validation
swift test: 2,003 tests in 167 suites passedswift build -c release: passedbuild-for-testing: passedgit diff --check: passedCloses #70
Closes #71
Closes #73
Closes #74