Repository navigation
Harbor's pages look finished in a site with no stylesheet of its own - #33
Merged
Merged
Conversation
Harbor's pages are drawn with a set of colours and component classes (card, pill, meta, display, field, btn-primary, btn-quiet, chip, log-pre; ink, soft, hairline and the pale status colours) that only the first host defined. In a blank Rails app every page worked and none had cards, buttons or spacing. Harbor's entry stylesheet now defines them (harbor/theme.css) and gives the page beside the side nav room around it. The components are in the base layer and the colours are tokens, so a host's own definitions win; it sets no font and nothing on body. The README's setup steps are brought up to date: pages are under /factory. Found by setting Harbor up in a blank app and opening every page. 0.27.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harbor's pages are drawn with colours and component classes (
card,pill,meta,display,field,btn-primary,btn-quiet,chip,log-pre;ink,soft,hairlineand the pale status colours) that only the first host defined. In a blank Rails app every page worked and none had cards, buttons or spacing.Harbor's entry stylesheet now defines them (
harbor/theme.css) and gives the page beside the side nav room around it. The components are in the base layer and the colours are tokens, so a host's own definitions win. It sets no font and nothing onbody.The README's setup steps are brought up to date: pages are under
/factory.Checked two ways: a blank Rails 8.1 app following the README, where all 48 pages load and now look finished; and the first host, where screenshots of eight pages at two widths are byte-identical before and after apart from a relative timestamp.
0.27.0.