Repository navigation
Overview and Velocity are Harbor's (0.26.0) - #32
Merged
Merged
Conversation
…bor's records, and the stage notes Harbor::OverviewController serves the section's front page at the section's own address (/factory). It is read from the records each time it is drawn: one number for each thing Harbor keeps (Harbor::Overview::Summary), who does each kind of work, what runs it (Harbor::Overview::Snapshot), how long it takes and what it costs (Harbor::Overview::Timings), and what changed lately (Harbor::Overview::Changes). Harbor::StageNote, on the factory_notes table (the migration creates it when it is missing), is the one thing written by hand: a note per stage, edited in place and handed to config.export. Harbor::VelocityController serves /factory/velocity over a range, with three tabs from Harbor's own records: Runs, Spending and Scorers (Harbor::Velocity::Runs, Spending and Scoring). The menu's Overview and Velocity entries are the engine's own routes, so every page of the menu is Harbor's and a site with no code of its own has all of it. The dummy app's menu tests use the page it adds itself (Reports) as the page a host owns. A site that declares nothing has one stage holding everything. A host declares its stages, more lines under a stage, ways in, steering rows, change sources, tiles and sections (Harbor::Overview), and tabs and tiles (Harbor::Velocity). It says the headings in its own words and adds cards with partials (harbor/overview/_intro and _note_form_hint, harbor/velocity/_intro, _spending_cards and _runs_cards), and says how markdown is drawn (config.markdown). Which agents count as edited on their page, an agent's effort and what starts an automation are the host's classes' to say (Harbor::Agent.edited_here, #effort_label, Harbor::Automation#trigger_data). 0.26.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview and Velocity move into Harbor. With this every page of the menu is the engine's own route, so a site with no code of its own has the whole section.
What a site with no code of its own gets
Overview (
/factory, the section's own address), read from the records each time it is drawn:Harbor::StageNoteonfactory_notes(the migration creates the table when it is missing), handed toconfig.exporton every save.Velocity (
/factory/velocity), over the last 7, 30 or 90 days, 12 weeks or 6 months:What a host adds
Harbor::Overview:stage,part,way_in,steer,change_source,tile,section,hide_section.Harbor::Velocity:tab,remove_tab,tile.harbor/overview/_intro,harbor/overview/_note_form_hint,harbor/velocity/_intro,harbor/velocity/_spending_cards,harbor/velocity/_runs_cards.config.markdown;Harbor::Agent.edited_hereand#effort_label;Harbor::Automation#trigger_data.README sections "Overview" and "Velocity" have the details, and the changelog has "Upgrading from 0.25".
Notes
turbo-rails(the dummy app) still draws and saves a note.path: /), Overview is at/overview, because the root is the host's.Checked
bin/test: 940 runs, 8275 assertions, 0 failures, 0 errors, 0 skips.bundle exec rubocop: no offenses.