fix(ci): repair lint/codecov, upgrade and SHA-pin actions - #5
Merged
gofreight-jackyeh merged 2 commits intoMay 15, 2026
Merged
gofreight-jackyeh merged 2 commits into
gofreight-jackyeh merged 2 commits into
Conversation
gofreight-jackyeh
changed the title
gofreight-jackyeh
force-pushed
the
fix/ci-self-hosted-runners-and-pinned-actions
branch
2 times, most recently
from
May 15, 2026 04:57
66f7ca9 to
60dad4b
Compare
Address the failing CI run (linting + unit_tests_with_coverage) and the Node.js 20 deprecation warnings across all three workflows. - Remove dead `@angular-eslint/no-host-metadata-property` references (rule was removed upstream; inline disables broke linting) - Replace unmaintained `npx codecov` (TypeError on upload) with `codecov/codecov-action` - Upgrade deprecated actions (checkout/cache/upload-artifact/ cancel-workflow-action) to Node 20-supported versions - Pin every action to commit SHA with the floating tag preserved as a trailing comment (notably s0/git-publish-subdir-action, which was tracking a moving branch) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
gofreight-jackyeh
force-pushed
the
fix/ci-self-hosted-runners-and-pinned-actions
branch
from
May 15, 2026 04:58
60dad4b to
1f4a503
Compare
Playwright 1.35.1 (June 2023) predates Ubuntu 24.04. Its `install-deps` step apt-installs `libasound2`, which on noble was renamed to `libasound2t64`, causing `E: Package 'libasound2' has no installation candidate` and failing all e2e jobs once `ubuntu-latest` rolled to 24.04. Pinning the two e2e jobs to `ubuntu-22.04` is the minimal fix and keeps the rest of the workflow on `ubuntu-latest`. A future Playwright bump can revert this. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gofreight-jackyeh
enabled auto-merge (squash)
May 15, 2026 07:30
yingray
approved these changes
May 15, 2026
gofreight-jackyeh
deleted the
fix/ci-self-hosted-runners-and-pinned-actions
branch
May 15, 2026 07:34
CJHwong
added
the
gobuilders:N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address the failing CI run #25102891860 (2 errors, 10 warnings) without altering the runner setup — this repo is public, so self-hosted runners are off the table.
Linting failure
@angular-eslint/no-host-metadata-propertyno longer exists in newer@angular-eslint. Three components carried inlineeslint-disable-next-linedirectives for it, andsrc/datepicker/.eslintrc.jsonset the rule itself — both producedDefinition for rule … was not found. Removed the dead references.Unit-test (codecov) failure
codecovnpm package crashed withTypeError: result.split is not a functionagainst the current Codecov response format. Replacednpx codecovwithcodecov/codecov-action(stillcontinue-on-error: true). Optionally setCODECOV_TOKENrepo secret to enable uploads.Node 20 deprecation warnings (10 jobs)
actions/checkout@v3→@v4actions/cache@v3→@v4actions/upload-artifact→@v4styfle/cancel-workflow-action@0.11.0→@0.12.1Supply-chain hardening
uses:now pinned to commit SHA with the floating tag preserved as a trailing comment. Notably fixess0/git-publish-subdir-action@developwhich was tracking a moving branch.Out of scope (intentionally reverted)
Earlier drafts included
runs-on: [self-hosted, general, *]and a swap tohardcoretech/action-s3-cache. Both reverted in 8e53d8f — public repo + fork PRs would expose the internal EC2 fleet (IMDS access, etc.). Keeping GitHub-hostedubuntu-22.04/ubuntu-latest.Test plan
lintingjob passes (no moreno-host-metadata-propertyerrors)unit_tests_with_coveragejob passes; Codecov upload runs withoutTypeError(or fails gracefully viacontinue-on-error)🤖 Generated with Claude Code