Skip to content

Release request: slcan on Windows loses frames on 4.6.1, fixed on main #2121

Open

Description

@dcasnowdon

Hi @zariiii9003,

Could a 4.6.2 or 4.7.0 be released that includes #2028? On Windows, the slcan interface in 4.6.1 loses frames whenever the bus is busy, and #2028 fixes it, but it is only on main so far.

What we see. The device under test sends 10000 frames to a CANable adapter running slcan firmware. With 4.6.1 the host receives between some fraction of (about half) them, and then nothing more arrives. The same test on Linux receives all 10000 frames.

slcanBus._read in 4.6.1 calls serial.read(1) once per byte. On Windows each call is a separate request to the serial driver. Bytes are dropped.

#2028 fixes it...

Until there is a release, we replace slcanBus._read in our own test tooling.

Thanks for all your efforts with python-can!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions