Skip to content

fix(queue-storage): refresh SET-only lane repairs on 0.6 - #668

Merged
hardbyte merged 1 commit into
release/0.6.6from
brian/fix-set-only-lane-repair-0.6
Nov 7, 2026
Merged

hardbyte merged 1 commit into
release/0.6.6from
brian/fix-set-only-lane-repair-0.6

Conversation

@hardbyte

@hardbyte hardbyte commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Lane repair could reassign a legacy sequence to the schema owner and then lose the authority needed to finish its runtime grants when the migrator had SET-only membership. This backports the repair from #637: discovery accepts that membership, repair temporarily activates the new owner when needed, and restores the exact previous role.

The repeatable definer_lane_provisioning patch now detects an older installed repair helper and refreshes it instead of skipping it merely because the function exists. The schema remains v40. The body marker identifies this helper generation; it is not a full definition or ACL integrity check. The upgrade guide runs migration before lane diagnostics and documents explicit helper/schema grants.

Validation:

  • Root and Python-workspace formatting, all-target/all-feature Clippy, and workspace builds passed.
  • Seven focused tests passed on each of PostgreSQL 17.11 and 18.6, including binary-first and migrate-first behavior, stale-helper refresh, SET-only repair, grants and role restoration.
  • Reversing only the stale-helper detection probe makes the unchanged regression fail at its pending-patch assertion on both majors.
  • Full CI passed: all 31 jobs, including PostgreSQL 17/18, the prune engine job, migrations, Python 3.14/3.15 and frontend E2E.

@hardbyte hardbyte added the full-ci Run the full CI matrix (Python build+test, E2E) on this PR label Nov 7, 2026 — with ChatGPT Codex Connector
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:31:07.075021Z 0825d37 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38a2e0e7-6bb8-4951-b4cb-866eca3e9510

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hardbyte
hardbyte merged commit 356758e into release/0.6.6 Nov 7, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Run the full CI matrix (Python build+test, E2E) on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant