Skip to content

fix(queue-storage): ignore retired ready rows in point reads (0.6) - #651

Merged
hardbyte merged 1 commit into
release/0.6.6from
brian/fix-live-ready-point-reads-0.6
Nov 6, 2026
Merged

hardbyte merged 1 commit into
release/0.6.6from
brian/fix-live-ready-point-reads-0.6

Conversation

@hardbyte

@hardbyte hardbyte commented Nov 6, 2026

Copy link
Copy Markdown
Owner

After a priority or queue move, the retained source ready row and live destination can have identical attempt timestamps. A ring wrap can make get_job choose the source row, returning the old priority or queue even though the batch operation reports success.

Exclude ready rows with a tombstone matching their full slot, generation and lane identity from the available-job point-read candidates. Keep retained rows available to the running and terminal hydration paths.

This predates 0.6.13 and explains the priority4-versus1 failures seen in #629 and #638 CI. Two public-API regressions wrap child7 to child0, move priority/queue, prove the source is tombstoned, and require the live value. Both fail before the fix and pass on PostgreSQL17/18 after it. The original failing batch-operation test also passes with the forced wrap.

Required fmt, offline all-target/all-feature Clippy (-D warnings), and workspace build pass. Main counterpart is included in #600. No migration.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2d696f0-99be-491b-aaaa-222bac37486e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T09:34:47.496388Z 9dcb8c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Run the full CI matrix (Python build+test, E2E) on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant