Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 6, 2026
21 tasks
Owner
Author
|
Parked under the branch policy now recorded in #383. Fixes land on Generated by Claude Code |
Owner
Author
|
Superseded: main already keeps finalizing attempts in the heartbeat registry until completion commits (FinalizationHeartbeatGuard). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handler can return while its completion write is still queued or blocked. Removing that attempt from the heartbeat registry lets rescue run the job again before its first completion commits.
Keep the attempt registered through finalization and release it with a drop guard created before the finalizer-capacity wait. Finalizing attempts stop flushing progress. Heartbeats skip held closer locks, use a fresh statement snapshot to check closure evidence, and cannot recreate state for a closed claim. Legacy lease and canonical progress updates skip locked rows; skipped progress remains eligible for retry.
Validation: The stalled-finalizer regression uses a separate trigger gate after completion owns all of its attempt locks, then holds it for four five-second staleness windows. The identical fixture fails with duplicate executions before the heartbeat-retention fix and passes afterward on PostgreSQL 17 and 18, retaining durable-completion and exact-execution assertions. A measured WAL-sync delay let the earlier one-second fixture reach 1.315s of heartbeat age under contention; the new margin keeps that capacity limit separate from the retention invariant.
Required formatting, offline all-target/all-feature Clippy (-D warnings), and workspace build pass. Full CI is temporarily deferred while the approved release merge checks run.
No schema migration.