Skip to content

ci(release): take release notes from the CHANGELOG.md section for the tag (0.6) - #496

Merged
hardbyte merged 4 commits into
release/0.6.6from
ci/release-notes-from-changelog-0.6
Nov 3, 2026
Merged

hardbyte merged 4 commits into
release/0.6.6from
ci/release-notes-from-changelog-0.6

Conversation

@hardbyte

Copy link
Copy Markdown
Owner

Backport of the same change proposed for main, so the next 0.6 patch release gets its body from CHANGELOG.md.

Problem

The v0.6.8 draft was created with gh release create --generate-notes and published with an empty body; the notes had to be written by hand afterwards, although the ## [0.6.8] section already existed in CHANGELOG.md.

Change

A new step before "Create or verify draft release" extracts the ## [<tag without v>] section from CHANGELOG.md, appends a **Full changelog** compare link against the previous tag of the same minor, and the draft is created with --notes-file. Without a matching section the draft falls back to --generate-notes. The immutable-release ordering (draft first, assets, registries, publish) is unchanged.

Validation

  • awk extraction run locally against this branch's CHANGELOG.md: the 0.6.8 section is found and bounded at ## [0.6.7]; the previous tag resolves to v0.6.7.
  • Workflow YAML parses. The step runs on the next 0.6 tag.

… tag

The draft release was created with --generate-notes, which yields a
pull-request list at best and produced an empty body for v0.6.8, while the
curated notes already live in CHANGELOG.md. The draft step now extracts the
`## [x.y.z]` section matching the tag, appends a compare link against the
previous tag of the same minor, and passes it as the release body. A tag
without a section falls back to generated notes.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T02:14:49.619575Z 4a06a5e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a06a5e388

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +260 to +264
awk -v ver="$version" '
index($0, "## [" ver "]") == 1 { found = 1; next }
found && /^## \[/ { exit }
found { print }
' CHANGELOG.md > release-notes.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Check out the repository before extracting notes

On every tag-triggered run, prepare-github-release starts on a fresh runner and, unlike version-check, contains no actions/checkout step. Consequently CHANGELOG.md is absent, so this awk command exits nonzero under set -euo pipefail before the draft can be created; even if that were bypassed, the later git fetch would not be inside a repository. Add a checkout step to this job before extraction.

Useful? React with 👍 / 👎.

The prepare-github-release job had no checkout, so the new extraction step
would fail on the missing CHANGELOG.md and stop the release before the draft
was created.
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7d5c017f-6976-4fac-ac96-55f8823e0e28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

Rust 1.99's clippy flags the must_use that async-trait 0.1.89 puts on
the boxed future of Worker::perform. main already locks 0.1.92, whose
expansion passes; the 0.6 lockfiles follow it.

hardbyte commented Nov 3, 2026

Copy link
Copy Markdown
Owner Author

Rust lint (fmt + clippy) failed on 0470e8fe with clippy 1.99's double_must_use, raised inside the async_trait expansion in awa-worker/src/executor.rs. This PR doesn't cause it: the lint fails on release/0.6.6 as well, because the newer stable toolchain introduced it. The fix is the async-trait 0.1.92 bump from #582 (8934c3a0). I've cherry-picked it here as 1b0d63b3. It's an identical lockfile change, so it won't conflict whichever PR merges first. cargo clippy -p awa-worker --all-targets -- -D warnings passes locally.

This push also adds actions/checkout to prepare-github-release (b461aa29). Without it, the new step can't read CHANGELOG.md and the release stops before the draft is created.


Generated by Claude Code

@hardbyte
hardbyte merged commit 6d46d1e into release/0.6.6 Nov 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants