Repository navigation
Conversation
…l call Every finished shell or edit tool rescans the project listing (a shell tool twice), and each scan stored a fresh array and notified everyone, so every mounted composer of that checkout, hidden tabs included, rebuilt its mention index even though nothing on disk had changed. On a 15,000-file root with 23 sessions open that was about a second of main thread per tool call. - An unchanged rescan keeps the previous array and notifies no one; the last listing per checkout survives invalidation so it can be compared. - Composers with the same listing and notes share one mention index. - A composer in an inactive tab lets go of the listing until shown again.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the main change: preventing repeated @-mentionindex rebuilds after agent tool calls.Description check The description includes all required sections, explains the change and rationale, documents UI impact, and completes the checklist. The added validation details provide useful supporting context. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
loadProjectFileskeeps the previous array when a rescan returns the same listing (same paths andisDir, in order) and doesn't notify subscribers. The last listing per checkout is kept throughinvalidateProjectFiles(cwd)(bounded atCACHE_LIMIT * 2) so the comparison still works after the cache entry is dropped; a fullinvalidateProjectFiles()clears it.sharedMentionIndex(files, extras)infileMentions.ts: composers holding the same listing (and the same notes) share oneMentionIndex(aWeakMapkeyed by the listing array, at most 4 note sets per listing) instead of each building its own.enabled === false) stops holding the project listing and picks it up from the cache again when shown.Why
When a shell tool finishes,
nudgeOpenEditorsinApp.tsxcallsnudgeWorkspace(cwd)twice (immediately and 150 ms later), and a finished edit tool calls it once. Each call runsinvalidateProjectFiles(cwd)+notifyDirsChanged(), which rescans the checkout. Every scan stored a fresh array and callednotifyProjectFilesChanged(), so every mountedComposerfor that checkout, hidden tabs included, got a newfilesarray and re-ranbuildMentionIndexin its ownuseMemo, even though nothing on disk had changed.buildMentionIndexis linear in the listing but not cheap: about 16 ms for 15,000 paths in Node (below), and about 50 ms in a real window on a 15,000-file multi-repo root. With 23 sessions open on that root, every agent tool call cost about 1.1 s of main thread, enough to break an IME composition or swallow a click. A heap snapshot of that window also held about 170,000 file entries, mostly the per-composer copies kept by hidden tabs.UI
No visual change.
@suggestions behave the same; a hidden tab's composer reloads its listing from the cache when shown.Validation
main:fileIndex.test.ts› "keeps the same array and stays quiet when a rescan finds nothing new" (thetoBeidentity check fails onmain)fileMentions.test.ts› "sharedMentionIndex builds once per listing and extras, matching a direct build"buildMentionIndex: ~16 mssharedMentionIndex): ~16 msnpm run check:web: vitest (5365 passed, 13 skipped) andtsc --noEmit. No Rust changes.Checklist
npm run check(check:web; no Rust files changed)Summary by CodeRabbit