fix: allow Unicode domains in URI validation - #3133
Open
jackwalkerlabs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3068
The URI regex rejected non-ASCII hosts before the Unicode-aware domain validation ran. This adds a validation-only fallback that percent-encodes non-ASCII characters for structural matching only when all encoding changes are confined to the captured host. The original Unicode domain is then checked with the configured domain rules, and the input stays unchanged unless
encodeUriconversion was requested.Tests cover raw Unicode hosts, relative URIs, percent-encoded paths,
allowUnicode: false,convert: false, existingencodeUribehavior, Unicode outside the host, and malformed surrogate input.Validation:
npm teston Node 25.8.2: 1,819 tests, 100% coverage, lint, types, and leak checks cleanAI assistance: used for investigation, implementation, and test review; every submitted change and validation result was reviewed.