Use call note text from highest priority source - #216
Open
alduhoo wants to merge 1 commit into
Open
Conversation
sd
requested changes
May 8, 2026
sd
left a comment
Contributor
There was a problem hiding this comment.
It might be a bit confusing, but priority is first note found within a file, but last file in the list.
This is because if you add a new file, you expect it to have priority. Otherwise the default Ham2K Notes file would always take precedence unless you reordered them.
One alternative would be to change the logic to what you propose here, but it would also require a migration to reorder files each user might have already added, and changing the way the UI works so that new files are added on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call note extension has support for updating the call note source priority. When fetching the note text to display, the text from the last source was being returned (this was expected before the priority re-ordering change). To simplify things and have the text match the expectations of the prioritized list, return the note text from the first source.