Skip to content

Add version info#243

Open
Boldewyn wants to merge 4 commits into
mainfrom
add_version_info
Open

Add version info#243
Boldewyn wants to merge 4 commits into
mainfrom
add_version_info

Conversation

@Boldewyn
Copy link
Copy Markdown
Contributor

This changeset adds version information to two places:

  • a new command version prints the current version of the tool
  • during runs the steps write their used version into the workspace DB as log messages with level info

The clean-up of phpunit files is unrelated, but seemed not to merit its own pull request.

Boldewyn added 4 commits May 22, 2026 09:58
A bit of automation is sketched with the release.yaml workflow, but at
the moment updating VERSION is still a manual process.

ERM47998
@Boldewyn Boldewyn force-pushed the add_version_info branch from bf9fcbf to fe69864 Compare May 22, 2026 07:58
Copy link
Copy Markdown
Contributor

@DvogelHallowelt DvogelHallowelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general a good solution but do we really need to add the information for each step to the database?
Keep in mind analyze and extract do run multiple times fi more then one spaces are migrated. converter always runs multiple times.

In my opinion it would be enough to add this in the compose step to the database and the log files.

@Boldewyn
Copy link
Copy Markdown
Contributor Author

Yes, agreed, it is not useful to fill the logging table with many message instances for a single run.

OTOH for reporting, long-running migration projects, and general accountability it would be good, if every invocation of analyze, extract, convert and compose would leave exactly one message. I’ll try to move the logging in the analyze and extract steps to a place where it will be called only once per command execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants