Skip to content

Ask ipwho.is only when needed; F-Droid draft as reviewed - #22

Merged
halilkhrmn merged 2 commits into
mainfrom
ccr-f02f85b0-9qbfqp
Oct 3, 2026
Merged

halilkhrmn merged 2 commits into
mainfrom
ccr-f02f85b0-9qbfqp

Conversation

@halilkhrmn

@halilkhrmn halilkhrmn commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

This PR answers the F-Droid static review on fdroiddata!50840 (note 3950015262) and syncs the F-Droid draft.

The review. The reviewer checked VirusTotal (0/68), that the build matches our signed APK, the VPN scope and the argument policy, and found nothing wrong there. The one request: the app sent the phone's IP address to ipwho.is on first start, before the wizard, with no way to turn it off.

What changes.

  • NetworkIdentity looks up the provider on each new network only when the automatic strategy is on and the wizard is done.
  • A test the user starts (the Lab, or the wizard's "Test" button) can still look it up. The wizard no longer looks it up when it opens.
  • New setting: Settings → "Look up the network provider". When it is off, no lookup happens at all.
  • Without the lookup, the per-network memory still tells mobile operators apart (MCC+MNC). On Wi-Fi the profile's own strategy is used. See DECISIONS #27.
  • The store descriptions (5 languages), the READMEs and the site now say what goes to ipwho.is, to GitHub and to the DNS server. "No tracking" became "no analytics".

F-Droid draft. docs/fdroid/ is now the MR's file as reviewed: only 0.2.0, pinned to its full commit hash, category VPN & Proxy.

Verified:

  • :core:test and :app:testDebugUnitTest pass, and lint is unchanged.
  • The store images were rendered again; the settings screen shows the new switch.
  • Not yet checked on a phone with network traffic.

Only 0.2.0, pinned to its commit hash; category VPN & Proxy.
From F-Droid's review: the provider lookup sent the IP address to
ipwho.is on first start. It now runs on new networks only with the
automatic strategy after the wizard, or for a test the user starts, and
Settings can turn it off. Store texts, READMEs and the site say which
services the app talks to.
@halilkhrmn halilkhrmn changed the title F-Droid draft as in the reviewed merge request Ask ipwho.is only when needed; F-Droid draft as reviewed Oct 3, 2026
@halilkhrmn
halilkhrmn merged commit d4a8db5 into main Oct 3, 2026
6 checks passed
@halilkhrmn
halilkhrmn deleted the ccr-f02f85b0-9qbfqp branch October 3, 2026 21:38
@halilkhrmn halilkhrmn mentioned this pull request Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant