Repository navigation
Ask ipwho.is only when needed; F-Droid draft as reviewed - #22
Merged
Merged
Conversation
Only 0.2.0, pinned to its commit hash; category VPN & Proxy.
From F-Droid's review: the provider lookup sent the IP address to ipwho.is on first start. It now runs on new networks only with the automatic strategy after the wizard, or for a test the user starts, and Settings can turn it off. Store texts, READMEs and the site say which services the app talks to.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR answers the F-Droid static review on fdroiddata!50840 (note 3950015262) and syncs the F-Droid draft.
The review. The reviewer checked VirusTotal (0/68), that the build matches our signed APK, the VPN scope and the argument policy, and found nothing wrong there. The one request: the app sent the phone's IP address to ipwho.is on first start, before the wizard, with no way to turn it off.
What changes.
NetworkIdentitylooks up the provider on each new network only when the automatic strategy is on and the wizard is done.F-Droid draft.
docs/fdroid/is now the MR's file as reviewed: only 0.2.0, pinned to its full commit hash, categoryVPN & Proxy.Verified:
:core:testand:app:testDebugUnitTestpass, and lint is unchanged.