Repository navigation
Typed sites: no early pills, testable in the Lab and wizard - #21
Merged
Merged
Conversation
Some keyboards put a space after a dot, which made a pill of an unfinished name; only finished names become pills now, and autocorrect is off. Packs are optional in the Lab and the wizard: sites typed by hand are tested and join the profile. F-Droid draft pins builds to commit hashes and adds 0.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the early-pill bug in the domain field, lets typed sites be tested in the Lab and wizard, and updates the F-Droid draft.
Domain field bug. In the profile editor, typing a dot turned an unfinished name into a pill. Some keyboards (Samsung's address keyboard) add a space after
., and the field treated that space as a separator.Hostlist.splitTypedmakes a pill only from a finished name: one with a dot inside and not at the end.example.stays in the field asexample..https://host/pathstill becomeshost.Typed sites in the Lab and wizard. The pill field moved to
DomainInput.ktand is now also in the Strategy Lab and the wizard.F-Droid. The review on fdroiddata!50840 asked for the full commit hash instead of the tag. The draft in
docs/fdroid/now pins 0.1.0 toaeb82d0…and adds the 0.2.0 build (e904087…, thev0.2.0tag).Verified:
HostlistInputTestcovers a space after a dot, URLs and words without a dot.:core:testand:app:testDebugUnitTestpass and lint is unchanged.