Skip to content

Typed sites: no early pills, testable in the Lab and wizard - #21

Merged
halilkhrmn merged 1 commit into
mainfrom
ccr-f02f85b0-9qbfqp
Oct 2, 2026
Merged

halilkhrmn merged 1 commit into
mainfrom
ccr-f02f85b0-9qbfqp

Conversation

@halilkhrmn

@halilkhrmn halilkhrmn commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

This PR fixes the early-pill bug in the domain field, lets typed sites be tested in the Lab and wizard, and updates the F-Droid draft.

Domain field bug. In the profile editor, typing a dot turned an unfinished name into a pill. Some keyboards (Samsung's address keyboard) add a space after ., and the field treated that space as a separator.

  • Hostlist.splitTyped makes a pill only from a finished name: one with a dot inside and not at the end. example. stays in the field as example..
  • A pasted address like https://host/path still becomes host.
  • A word without a dot is not a site.
  • Autocorrect is off in the field.

Typed sites in the Lab and wizard. The pill field moved to DomainInput.kt and is now also in the Strategy Lab and the wizard.

  • Packs are optional. Sites typed by hand are tested on their own or together with packs.
  • The Lab starts with the selected profile's extra domains.
  • Typed sites are added to the profile the result is used for. A new profile without packs is named after its sites.

F-Droid. The review on fdroiddata!50840 asked for the full commit hash instead of the tag. The draft in docs/fdroid/ now pins 0.1.0 to aeb82d0… and adds the 0.2.0 build (e904087…, the v0.2.0 tag).

Verified:

  • HostlistInputTest covers a space after a dot, URLs and words without a dot.
  • :core:test and :app:testDebugUnitTest pass and lint is unchanged.
  • I looked at the Lab and wizard renders, and the store images were rendered again.

Some keyboards put a space after a dot, which made a pill of an
unfinished name; only finished names become pills now, and autocorrect
is off. Packs are optional in the Lab and the wizard: sites typed by
hand are tested and join the profile. F-Droid draft pins builds to
commit hashes and adds 0.2.0.
@halilkhrmn
halilkhrmn merged commit 2f5bbd3 into main Oct 2, 2026
6 checks passed
@halilkhrmn
halilkhrmn deleted the ccr-f02f85b0-9qbfqp branch October 2, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant