Repository navigation
Site packs from the desktop's domains.json - #19
Merged
Merged
Conversation
The desktop app keeps its packs in strategies/domains.json (translated names, countries); read that file instead of packs.json. Pack chips and new profile names use the translated name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18. In the meantime the desktop app had moved its site packs to
strategies/domains.json, so Android now reads that file instead ofpacks.json.core/src/main/resources/strategies/domains.json. The list update downloads the newest copy from desktopmain.names: translated pack names. Pack chips and new profile names use them.countries: read and checked, not used yet.android_packages: added on desktop by Android package names in domains.json dpimech#17.Merge halilkhrmn/dpimech#17 first. Until then the downloaded file has no
android_packages, so packs would not tick apps. The embedded copy already has them.Verified:
:core:testpasses (CatalogTest: names, countries, ids, bad files).:app:testDebugUnitTestpasses and lint is unchanged.