Skip to content

Potential fix for code scanning alert no. 3: Workflow does not contain permissions#5

Merged
halbothpa merged 6 commits into
mainfrom
alert-autofix-3
May 20, 2026
Merged

Potential fix for code scanning alert no. 3: Workflow does not contain permissions#5
halbothpa merged 6 commits into
mainfrom
alert-autofix-3

Conversation

@halbothpa
Copy link
Copy Markdown
Owner

Potential fix for https://github.com/halbothpa/flipper-dev-toolkit/security/code-scanning/3

Add an explicit workflow-level permissions block in .github/workflows/ci.yml so all jobs default to least privilege.
The best minimal fix (without changing functionality) is:

  • Add at the top level (after on: block, before jobs:):
    • permissions:
    • contents: read

This is sufficient for actions/checkout and read-only CI tasks in the shown jobs. No imports, methods, or dependencies are needed.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

halbothpa and others added 3 commits May 19, 2026 23:45
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@halbothpa halbothpa marked this pull request as ready for review May 19, 2026 21:54
Copilot AI review requested due to automatic review settings May 19, 2026 21:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit workflow-level permissions block to address GitHub code scanning alert #3 and ensure the CI workflow defaults to least privilege.

Changes:

  • Add top-level permissions: with contents: read in .github/workflows/ci.yml so all jobs inherit read-only repo access by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

halbothpa added 2 commits May 20, 2026 01:14
Potential fix for code scanning alert no. 2: Workflow does not contain permissions
Potential fix for code scanning alert no. 1: Workflow does not contain permissions
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@halbothpa halbothpa merged commit 7c91947 into main May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants