fix: use local brands API for update entity picture#5339
Draft
CervezaStallone wants to merge 1 commit into
Draft
fix: use local brands API for update entity picture#5339CervezaStallone wants to merge 1 commit into
CervezaStallone wants to merge 1 commit into
Conversation
Since HA 2026.3.0, brand images are served through the local API
(/api/brands/integration/{domain}/icon.png) instead of the external CDN.
Custom integrations can now ship their own brand images in a brand/
subdirectory, but the update entity was still pointing at the CDN URL
which returns a generic placeholder for unknown domains — causing HA
to display 'icon not available' for any custom integration not listed
in the official brands repository.
Fixes icon display for all custom integrations that ship a brand/
directory per the HA 2026.3 spec.
ludeeus
requested changes
Jun 30, 2026
| return None | ||
|
|
||
| return f"https://brands.home-assistant.io/_/{self.repository.data.domain}/icon.png" | ||
| return f"/api/brands/integration/{self.repository.data.domain}/icon.png" |
Member
There was a problem hiding this comment.
This needs to point to the brand's website if you are using HA < 2026.3.0, as that Path does not exist before it.
Can you also access this without a token?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since HA 2026.3.0, brand images are served through the local HA API (
/api/brands/integration/{domain}/icon.png) instead of being fetched directly from the external CDN by the browser. Custom integrations can now ship their own brand images in abrand/subdirectory (announcement).However,
update.pystill constructs the entity picture URL pointing at the CDN:The CDN returns a generic placeholder PNG (200 OK, ~3 KB) for any domain not listed in the official brands repository. HA's frontend detects this placeholder and displays "icon not available" — so custom integrations that correctly ship a
brand/directory still show no icon in the Updates card.Fix
Using the relative local API path routes the request through HA's backend, which serves from the integration's local
brand/directory when present, and falls back to the CDN for official integrations. This fixes icon display for all custom integrations that follow the HA 2026.3 spec.Impact
brand/directory: icon now shows correctlybrand/directory: HA returns a fallback, same as before