Adds new integration [ifMike/homeyHASS]#6696
Conversation
Include Homey Integration repository in HACS default integrations catalog.
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
frenck
left a comment
There was a problem hiding this comment.
Thanks for the integration, and for the thorough work here. The codebase is solid and well documented.
There's a blocker on the catalog side, though: the domain collides with an integration already in the HACS default catalog. Your manifest.json declares domain: "homey", but RonnyWinkler/homeassistant.homey is already published with that same domain. Both integrations install into custom_components/homey/, so a user can't have both, and the domain becomes ambiguous. The validation actions don't catch this because they only check your repository in isolation, not against the rest of the catalog.
Could you rename your integration's domain to something unique (for example homey_pro, or another name that's distinctly yours) and cut a new release? That means updating the domain key in manifest.json and the custom_components/<domain>/ directory name to match. Once that's done and a release is out, I'll take another look.
../Frenck
Blogging my personal ramblings at frenck.dev|
Hi @frenck — thanks for the review. I've addressed the domain collision in homeyHASS v2.0.0:
This is a breaking change for existing 1.x users (manual migration required). Release notes document that clearly. I've updated the PR description with the new release link. Marking ready for re-review. |
Resolves Sorted CI check on the HACS default PR branch.
Resolve integration list conflict by keeping both ideaalab/gui-recorder (from upstream) and ifMike/homeyHASS in case-insensitive sort order.
Checklist
Domain rename (addresses review feedback)
Per @frenck's review: the integration domain was renamed from
homeytohomey_hassin release v2.0.0 to avoid collision withRonnyWinkler/homeassistant.homey. The display name in Home Assistant remains Homey. Install folder:custom_components/homey_hass/.Links
Link to current release: https://github.com/ifMike/homeyHASS/releases/tag/v2.0.0
Link to successful HACS action (without the
ignorekey): https://github.com/ifMike/homeyHASS/actions/runs/27839287379Link to successful hassfest action: https://github.com/ifMike/homeyHASS/actions/runs/27839287379