Skip to content

Adds new integration [ifMike/homeyHASS]#6696

Open
ifMike wants to merge 10 commits into
hacs:masterfrom
ifMike:add-ifmike-homeyhass-v2
Open

Adds new integration [ifMike/homeyHASS]#6696
ifMike wants to merge 10 commits into
hacs:masterfrom
ifMike:add-ifmike-homeyhass-v2

Conversation

@ifMike

@ifMike ifMike commented Apr 2, 2026

Copy link
Copy Markdown

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Domain rename (addresses review feedback)

Per @frenck's review: the integration domain was renamed from homey to homey_hass in release v2.0.0 to avoid collision with RonnyWinkler/homeassistant.homey. The display name in Home Assistant remains Homey. Install folder: custom_components/homey_hass/.

Links

Link to current release: https://github.com/ifMike/homeyHASS/releases/tag/v2.0.0

Link to successful HACS action (without the ignore key): https://github.com/ifMike/homeyHASS/actions/runs/27839287379

Link to successful hassfest action: https://github.com/ifMike/homeyHASS/actions/runs/27839287379

Include Homey Integration repository in HACS default integrations catalog.
@hacs-bot hacs-bot Bot changed the title Add ifMike/homeyHASS to default integration list Adds new integration [ifMike/homeyHASS] Apr 2, 2026
@hacs-bot

hacs-bot Bot commented Apr 2, 2026

Copy link
Copy Markdown

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

  • Comment on the pull request - The reviewer will contact you when they have feedback or questions.
  • Open a new pull request - This won't speed up the process and creates duplicate work.
  • Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
  • Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

  • Approve and merge your pull request if everything meets the requirements
  • Request changes or ask questions if adjustments are needed

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration, and for the thorough work here. The codebase is solid and well documented.

There's a blocker on the catalog side, though: the domain collides with an integration already in the HACS default catalog. Your manifest.json declares domain: "homey", but RonnyWinkler/homeassistant.homey is already published with that same domain. Both integrations install into custom_components/homey/, so a user can't have both, and the domain becomes ambiguous. The validation actions don't catch this because they only check your repository in isolation, not against the rest of the catalog.

Could you rename your integration's domain to something unique (for example homey_pro, or another name that's distinctly yours) and cut a new release? That means updating the domain key in manifest.json and the custom_components/<domain>/ directory name to match. Once that's done and a release is out, I'll take another look.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@hacs-bot hacs-bot Bot marked this pull request as draft June 19, 2026 14:45
@ifMike

ifMike commented Jun 19, 2026

Copy link
Copy Markdown
Author

Hi @frenck — thanks for the review.

I've addressed the domain collision in homeyHASS v2.0.0:

This is a breaking change for existing 1.x users (manual migration required). Release notes document that clearly.

I've updated the PR description with the new release link. Marking ready for re-review.

@ifMike ifMike marked this pull request as ready for review June 19, 2026 17:17

@hacs-bot hacs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch seems out of date. Please update your branch with the latest changes from the base branch.

@hacs-bot hacs-bot Bot marked this pull request as draft June 19, 2026 17:17
@ifMike ifMike marked this pull request as ready for review June 19, 2026 17:20
Resolves Sorted CI check on the HACS default PR branch.

@hacs-bot hacs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit your PR to a single file change. This PR modifies 2 files. Please create separate PRs for each repository you want to add.

@hacs-bot hacs-bot Bot marked this pull request as draft June 19, 2026 17:20
@ifMike ifMike marked this pull request as ready for review June 19, 2026 17:22

@hacs-bot hacs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit your PR to a single file change. This PR modifies 2 files. Please create separate PRs for each repository you want to add.

@hacs-bot hacs-bot Bot marked this pull request as draft June 19, 2026 17:22
Resolve integration list conflict by keeping both ideaalab/gui-recorder
(from upstream) and ifMike/homeyHASS in case-insensitive sort order.
@ifMike ifMike marked this pull request as ready for review July 1, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants