chore(typescript): disable exactOptionalPropertyTypes#1150
Merged
Conversation
This setting is causing problems for us with one package we'd like to use: #1012 (comment) and is also preventing us from migrating to TypeScript 5 due to an upstream issue in `react-router` that's been unaddressed for almost a year: #898 There were no objections to disabling it, so we do so in this commit. (There is one minor code change required as a result, just an additional optional property check on a `onNodeClick` handler in our React Flow wrapper.) Closes #898 Signed-off-by: Drew Hess <src@drewhess.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting is causing problems for us with one package we'd like to use:
#1012 (comment)
and is also preventing us from migrating to TypeScript 5 due to an upstream issue in
react-routerthat's been unaddressed for almost a year:#898
There were no objections to disabling it, so we do so in this commit. (There is one minor code change required as a result, just an additional optional property check on a
onNodeClickhandler in our React Flow wrapper.)Closes #898