feat: render separate binders and names#1142
Merged
Merged
Conversation
For those nodes which have moved from `NodeFlavorTextBody` to `NodeFlavorNoBody` (things which used to have their text be the binding, such as lambdas), we now use white text on a solid background. Signed-off-by: George Thomas <georgefsthomas@gmail.com>
dhess
commented
Apr 9, 2024
dhess
force-pushed
the
dhess/separate-bind-nodes
branch
from
f4a3ceb to
157effa
Compare
Member
Author
|
Note for posterity: this is only the first commit from the branch https://github.com/hackworthltd/primer-app/tree/georgefst/separate-bind-nodes, but it's the one that's required to make the frontend work with the latest backend API changes (separating out binders from their names). There are 3 additional commits on that branch, all of which deal with styling of nodes, and I'd like to treat those separately so that they don't block forward progress on more pressing issues. I will open additional PRs to deal with those additional commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corresponds to the backend PR hackworthltd/primer#1183.
As noted in that backend PR, we cannot yet select the name nodes. We want to enable this, but it'll take some additional backend work. See hackworthltd/primer#75 and hackworthltd/primer#93.