Conversation
fetchWellKnownJSON created its own http.Client with a hardcoded 10s timeout, bypassing the httpx.Client that --proxy, --insecure, --timeout, --rate-limit, and the global retry policy are all threaded through. This meant OAuth metadata checks silently skipped the proxy, which broke interception with Burp or mitmproxy. - Accept *httpx.Client in fetchWellKnownJSON and use client.HTTP().Do() - Thread the client through BuiltinProbes(client) to the two probe structs that call the fetcher - Update cli.go to pass opts.client at the registration site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fetchWellKnownJSONcreated its ownhttp.Clientwith a hardcoded 10-second timeout, bypassing thehttpx.Clientthat--proxy,--insecure,--timeout,--rate-limit, and the global retry policy are all threaded through.This meant the two OAuth metadata checks (
mcp-oauth-metadata-postureandmcp-redirect-uri-laxity) silently skipped the proxy — breaking interception with Burp Suite or mitmproxy and ignoring the user's--timeoutsetting.Fix
*httpx.ClientinfetchWellKnownJSONand callclient.HTTP().Do(req)instead of a locally-constructed clientBuiltinProbes(client *httpx.Client)to the two probe structs that call the fetchertimeimportcli.goto passopts.clientat the registration siteThis matches the existing pattern in
internal/probe/transport, whereBuiltinProbes(client)already accepted the client for the same reason.