Align ASI codes and titles with the published Top 10 for Agentic Applications 2026 v1.0 - #11
Merged
Merged
Conversation
…ications 2026 v1.0 ASITitles in internal/report/report.go followed an earlier draft of the numbering (ASI04 to ASI09 carried different titles), and every asi_refs was coded against that draft. Update the table to the published v1.0 list, pin it with TestASITitles_MatchPublishedV1, and renumber the affected checks so each keeps the meaning it was given: - http-rate-limit-absence: ASI06 -> ASI08 (Cascading Failures); TestRateLimitProbe updated. - transport-plaintext, transport-downgrade: ASI04 -> ASI07 (Insecure Inter-Agent Communication, which the draft's ASI04 meant). - mcp-tmpl-high-risk-tool-names: ASI07 -> ASI05 (Unexpected Code Execution); ASI02 kept. docs/ASI_MAPPING.md: rows updated, template added, the two corrections now name draft and v1.0 codes side by side, plus a note on the table drift. The four ASI09 checks are left as they are on purpose. Refs hackwither#10.
Owner
|
hey looks good to me. thanks for the detailed description on your contribution |
hackwither
approved these changes
Sep 11, 2026
Contributor
Author
|
Thanks for the review and the merge, glad the description was useful. One point the PR left to you is still open on main: Avp9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
ASITitlesininternal/report/report.gofollowed an earlier draft of the numbering (ASI04 to ASI09 carried different titles), and everyasi_refswas coded against that draft. This updates the table to the published v1.0 list and renumbers the affected checks so each keeps the meaning it was given.Table
ASITitles: the ten published v1.0 titles.TestASITitles_MatchPublishedV1pins them. It fails against the previous table; a future change to the standard has to change the test on purpose.Codes, intent preserved
http-rate-limit-absence: ASI06 to ASI08 (Cascading Failures).TestRateLimitProbeupdated accordingly.transport-plaintext,transport-downgrade: ASI04 to ASI07 (Insecure Inter-Agent Communication, which is what the draft's ASI04 meant).mcp-tmpl-high-risk-tool-names: ASI07 to ASI05 (Unexpected Code Execution); ASI02 kept.Docs
docs/ASI_MAPPING.md: rows updated, the template added to the table, and the two "corrections" paragraphs now name the draft and v1.0 codes side by side, with a third paragraph recording the table drift itself.Left alone on purpose
The four checks citing ASI09 (
tls-cert-health,mcp-tool-capability-surface,mcp-dynamic-dispatch,mcp-instructions-exposure) recorded observability facts under a draft category the final list dropped. Whether to uncite them likemcp-auth-postureor keep ASI09 is your call; the mapping doc says so rather than deciding.Checks
gofmt -lempty,go vet ./...,go build ./...,go test -race ./...all pass on go1.22.12. The two new or changed assertions were confirmed to fail against the previousreport.goandtransport/checks.gorespectively before the fix was applied, so they are not passing by accident.