Skip to content

Feat/super admin batch roles#66

Open
tharunthunder wants to merge 4 commits intomainfrom
feat/superAdminBatchRoles
Open

Feat/super admin batch roles#66
tharunthunder wants to merge 4 commits intomainfrom
feat/superAdminBatchRoles

Conversation

@tharunthunder
Copy link
Copy Markdown
Collaborator

PR for super batch admin update

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't accept the incoming changes when you merged main -> your branch, make sure to use what main has for these

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, look at the lost comment to see what im talking about

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request payload is swapped but should be fine:

{
  "user_ids": ["uuid1", "uuid2"],
  "role": "admin"
}

The response payload should be:

{
  "data": {
    "updated": [
      { "id": "uuid1", "email": "alice@utdallas.edu", "role": "admin" },
      { "id": "uuid2", "email": "bob@utdallas.edu", "role": "admin" }
    ]
  }
}

you currently have:

{
  "users": [
    {
      "auth_method": "passwordless",
      "created_at": "string",
      "email": "string",
      "id": "string",
      "profile_picture_url": "string",
      "role": "hacker",
      "supertokens_user_id": "string",
      "updated_at": "string"
    }
  ]
}

}
if len(allowedOrigins) > 0 {
r.Use(cors.Handler(cors.Options{
AllowedOrigins: allowedOrigins,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is like a 95% chance changing the allowedOrigins is not allowed, you shouldn't have to edit configs

Check w/ Caleb

}

if err := Validate.Struct(req); err != nil {
app.badRequestResponse(w, r, err)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give a proper error message, i thought you didn't implement this feature

// @Summary Get or create application
// @Description Returns the authenticated user's hackathon application. If no application exists, creates a new draft application.
// @Tags hackers
// @Tags applications
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't accept the incoming changes when you merged main -> your branch, make sure to use what main has for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants