🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#220
🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#220hackerxj2010 wants to merge 1 commit into
Conversation
Identified and fixed a high-priority path traversal vulnerability in the `LocalJsonStore` class. The vulnerability allowed arbitrary JSON file read/write access on the host system via `..` segments and absolute paths in store keys. Fix includes: - Explicitly disallowing absolute paths for store keys. - Filtering out `.` and `..` segments from keys. - Handling cross-platform path separators (`/` and `\`). - Validating the resolved absolute path against the base directory prefix (with trailing separator check). - Added comprehensive security tests in `packages/documents/src/security.test.ts`. - Documented findings in `.jules/sentinel.md`. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal via
..segments and absolute paths inLocalJsonStorekeys.🎯 Impact: An attacker could read or write arbitrary JSON files on the host system, potentially leading to information disclosure or system compromise if sensitive files are targeted.
🔧 Fix: Implemented multiple layers of path validation and sanitization in
LocalJsonStore.toPath.✅ Verification: Created
packages/documents/src/security.test.tswith tests for relative and absolute path traversal. Verified that all existing unit tests pass.PR created automatically by Jules for task 3077077199798619241 started by @hackerxj2010