π‘οΈ Sentinel: [HIGH] Fix path traversal in LocalJsonStore#217
π‘οΈ Sentinel: [HIGH] Fix path traversal in LocalJsonStore#217hackerxj2010 wants to merge 1 commit into
Conversation
- Prevent absolute paths and '..' segments in LocalJsonStore keys - Implement prefix validation against resolved base directory - Add comprehensive security test suite - Update sentinel journal with findings Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Path traversal in
LocalJsonStoreclass within the@jeanbot/documentspackage.π― Impact: An attacker providing a malicious key (e.g.,
../../etc/passwd) could potentially read or write files outside the intended base directory.π§ Fix:
LocalJsonStore.toPathto reject absolute paths and paths containing.or..segments.path.resolve.β Verification:
packages/documents/src/security.test.tscovering absolute paths, relative traversal, encoded sequences, and Windows-style separators.pnpm testfrom the root, verifying all 52 tests across the monorepo pass.pnpm lintpasses for the modified package..jules/sentinel.md.PR created automatically by Jules for task 15927695176905117538 started by @hackerxj2010