Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in LocalJsonStore#217

Draft
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-local-json-store-traversal-15927695176905117538
Draft

πŸ›‘οΈ Sentinel: [HIGH] Fix path traversal in LocalJsonStore#217
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-local-json-store-traversal-15927695176905117538

Conversation

@hackerxj2010
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Path traversal in LocalJsonStore class within the @jeanbot/documents package.
🎯 Impact: An attacker providing a malicious key (e.g., ../../etc/passwd) could potentially read or write files outside the intended base directory.
πŸ”§ Fix:

  • Modified LocalJsonStore.toPath to reject absolute paths and paths containing . or .. segments.
  • Implemented canonicalization using path.resolve.
  • Added a prefix check against the resolved base directory with a trailing separator to prevent prefix bypass attacks.
    βœ… Verification:
  • Added comprehensive security tests in packages/documents/src/security.test.ts covering absolute paths, relative traversal, encoded sequences, and Windows-style separators.
  • Ran pnpm test from the root, verifying all 52 tests across the monorepo pass.
  • Verified pnpm lint passes for the modified package.
  • Created security journal in .jules/sentinel.md.

PR created automatically by Jules for task 15927695176905117538 started by @hackerxj2010

- Prevent absolute paths and '..' segments in LocalJsonStore keys
- Implement prefix validation against resolved base directory
- Add comprehensive security test suite
- Update sentinel journal with findings

Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant