Skip to content

Update how radio id is collected in overlay controller #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KisuHypee merged 1 commit into from
Jun 24, 2026
Merged

Update how radio id is collected in overlay controller #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions app/javascript/controllers/overlay_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,17 @@ export default class extends Controller {
if (!selectedOption || selectedOption.value === "") return; // Skip if 'Keep Empty'

const newValue = selectedOption.dataset.value;
const mainInput = document.getElementById(targetId);

if (mainInput) {
if (mainInput.type === "radio" || mainInput.tagName === "FIELDSET") {
const name = mainInput.name || `fields[${targetId.split("_")[1]}]`;
const radioToSelect = document.querySelector(
`input[name="${name}"][value="${newValue}"]`,
);
if (radioToSelect) radioToSelect.checked = true;

const fieldId = targetId.replace("fields_", "");
const fieldName = `fields[${fieldId}]`;

const mainInputs = document.querySelectorAll(`[name="${fieldName}"]`);

mainInputs.forEach((mainInput) => {
if (mainInput.type === "radio") {
if (mainInput.value === newValue) {
mainInput.checked = true;
}
} else if (mainInput.tagName === "SELECT") {
mainInput.value = newValue;
mainInput.dispatchEvent(new Event("change", { bubbles: true }));
Expand All @@ -131,7 +133,7 @@ export default class extends Controller {
mainInput.dispatchEvent(new Event("input", { bubbles: true }));
mainInput.dispatchEvent(new CustomEvent("text-editor:update", { detail: { value: newValue }}));
}
}
});
});

this.close(event);
Expand Down
Loading