dev #32

hanaeatsplanes · 2026-01-25T01:18:05Z

fix TS71007
uh
grrr
ship ship ship

vercel · 2026-01-25T01:18:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
aces	Ready	Preview, Comment	Jan 25, 2026 1:18am

Copilot

Pull request overview

This PR adds a "ship project" feature that allows users to mark projects as shipped when they have at least one devlog. It also includes several bug fixes and improvements including favicon path corrections, prop renaming for consistency, and a new shop redirect page.

Changes:

Added ship project functionality with UI button and API integration
Fixed favicon paths to include leading slashes
Renamed onCancel to onCancelAction in EditProject component
Created new shop redirect page with loading and error states
Modified devlogs API to convert empty descriptions to null
Updated hackatime projects date filter
Added Content-Type header to ship API route

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/components/dashboard/ProjectDetailsClient.tsx	Added ship project button with state management, error handling, and devlogCount prop
src/components/dashboard/EditProject.tsx	Renamed onCancel prop to onCancelAction and added React import for type annotations
src/components/Meta.tsx	Fixed favicon paths by adding leading slashes
src/app/dashboard/shop/page.tsx	New shop redirect page with Suspense boundary and error handling
src/app/dashboard/projects/[projectId]/page.tsx	Passed devlogCount to ProjectDetailsClient component
src/app/api/shop/form-url/route.ts	New API route for fetching shop form URL from environment variables
src/app/api/projects/[projectId]/ship/route.ts	Reordered imports and added Content-Type header; renamed unused parameter
src/app/api/hackatime/projects/route.ts	Updated start_date filter from 2025-12-01 to 2025-12-21
src/app/api/dashboard/devlogs/route.ts	Added type annotation and empty string to null conversion for description field

Copilot · 2026-01-25T01:23:02Z

src/components/dashboard/ProjectDetailsClient.tsx

+    try {
+      const res = await fetch(`/api/projects/${project.project_id}/ship`, {
+        method: "POST",
+        credentials: "include",


The credentials: "include" option on line 41 is unnecessary for same-origin requests in Next.js. The cookies are automatically sent with same-origin requests. This option is typically only needed for cross-origin requests with credentials. Consider removing it for clarity.

Suggested change

credentials: "include",

Copilot · 2026-01-25T01:23:03Z

src/app/dashboard/shop/page.tsx

+        const { formUrl } = await res.json();
+        const redirectUrl = `${formUrl}?item=${encodeURIComponent(item!)}`;
+        window.location.href = redirectUrl;


The redirectUrl constructed on line 32 should be validated to ensure the formUrl from the API is a trusted URL before redirecting. While the backend should control this, client-side validation would add defense in depth. Consider validating that formUrl is a known trusted domain before performing the redirect.

Copilot · 2026-01-25T01:23:03Z

src/app/api/dashboard/devlogs/route.ts

+  if (data.description === "") {
+    data.description = null;
+  }


The mutation of the parsed data on lines 16-18 occurs after type assertion but without proper type checking. Since the type annotation on line 10 doesn't provide runtime safety, the check data.description === "" could fail if description is undefined or missing. Consider restructuring this to avoid mutation and ensure type safety, for example: body: JSON.stringify({ ...data, description: data.description === "" ? null : data.description })

Copilot · 2026-01-25T01:23:03Z

src/app/dashboard/shop/page.tsx

+
+        if (!res.ok) {
+          const data = await res.json();
+          setError(data.error || "Failed to load shop configuration");


The error response on line 26 uses a generic "Failed to load shop configuration" message without including the backend's error detail. Consider extracting and including the error from the backend response to provide more context: setError(data.error || data.detail || "Failed to load shop configuration")

Suggested change

setError(data.error || "Failed to load shop configuration");

setError((data && (data.error || data.detail)) || "Failed to load shop configuration");

Copilot · 2026-01-25T01:23:03Z

src/components/dashboard/ProjectDetailsClient.tsx

              </button>
            </div>
+            {shipError && (
+              <p className="text-red-600 text-sm mt-2">{shipError}</p>


The error message displayed on lines 105-107 lacks accessibility attributes. Consider adding role="alert" and aria-live="polite" to the error container so screen readers announce the error when it appears.

Suggested change

<p className="text-red-600 text-sm mt-2">{shipError}</p>

<p

className="text-red-600 text-sm mt-2"

role="alert"

aria-live="polite"

>

{shipError}

</p>

Copilot · 2026-01-25T01:23:04Z

src/app/api/dashboard/devlogs/route.ts

  }

-  let data: unknown;
+  let data: { project_id: string; content: string; media_url?: string; description?: string | null };


The type annotation on line 10 is unsafe because req.json() returns any, which doesn't guarantee the data will match this type at runtime. Consider adding runtime validation using a library like Zod, or keeping the type as unknown and performing explicit type checking before using the data properties.

Copilot · 2026-01-25T01:23:04Z

src/components/dashboard/ProjectDetailsClient.tsx

+            {shipError && (
+              <p className="text-red-600 text-sm mt-2">{shipError}</p>
+            )}


The error message (lines 105-107) is placed as a third child in the flex container with justify-between (line 69). This will position the error horizontally alongside the project info and buttons, which is likely not the intended layout. Consider moving the error message outside this flex container (after line 108) or restructuring the layout to display the error below the buttons on a new line.

Copilot · 2026-01-25T01:23:04Z

src/components/dashboard/EditProject.tsx

+  onCancelAction,
 }: {
  projectId: number;
  initialData: ProjectData;
-  onCancel: () => void;
+  onCancelAction: () => void;


The prop name "onCancelAction" is unconventional. Standard React naming convention for callback props is "on[EventName]" without the "Action" suffix (e.g., "onCancel", "onClick"). While custom component props can have any name, following the conventional pattern makes the codebase more intuitive. Consider using just "onCancel" instead.

Copilot · 2026-01-25T01:23:04Z

src/app/dashboard/shop/page.tsx

+        }
+
+        const { formUrl } = await res.json();
+        const redirectUrl = `${formUrl}?item=${encodeURIComponent(item!)}`;


The non-null assertion operator (!) on line 32 is unnecessary because the item parameter is already checked for null/undefined on line 14, and the function returns early if it's falsy. You can safely use item without the assertion: ${formUrl}?item=${encodeURIComponent(item)}

Suggested change

const redirectUrl = `${formUrl}?item=${encodeURIComponent(item!)}`;

const redirectUrl = `${formUrl}?item=${encodeURIComponent(item)}`;

hanaeatsplanes added 4 commits January 16, 2026 11:32

fix TS71007

fc03b64

uh

9dc3948

grrr

ecb5567

ship ship ship

a621c4f

Copilot AI review requested due to automatic review settings January 25, 2026 01:18

Copilot started reviewing on behalf of hanaeatsplanes January 25, 2026 01:18 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

hackclub deleted a comment from Copilot AI Jan 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev #32

dev #32

Uh oh!

hanaeatsplanes commented Jan 25, 2026

Uh oh!

vercel bot commented Jan 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	setError(data.error \|\| "Failed to load shop configuration");
	setError((data && (data.error \|\| data.detail)) \|\| "Failed to load shop configuration");

	const redirectUrl = `${formUrl}?item=${encodeURIComponent(item!)}`;
	const redirectUrl = `${formUrl}?item=${encodeURIComponent(item)}`;

dev #32

Are you sure you want to change the base?

dev #32

Uh oh!

Conversation

hanaeatsplanes commented Jan 25, 2026

Uh oh!

vercel bot commented Jan 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants